Upgrade to v2 beta, JSON monitors are broken until re saved

[mmomjian]

📑 I have found these related issues/pull requests

N/A

🛡️ Security Policy

• I agree to have read this project Security Policy

Description

After an upgrade to v2, JSON monitors are broken until edited and re saved.

Error:

Monitor #174 'API check': Failing: Error evaluating JSON query: Invalid condition null. Response from server was: true | Interval: 600 seconds | Type: json-query | Down Count: 0 | Resend Interval: 0

When the monitor is edited, the correct info is populated, and when Saved the monitor comes back up.

(this screenshot is from a different monitor with the same issue, should say true)

👟 Reproduction steps

Setup a JSON monitor in v1 and upgrade to v2 beta

👀 Expected behavior

JSON monitors are preserved

😓 Actual Behavior

JSON monitors require re saving

🐻 Uptime-Kuma Version

2.0.0-beta

💻 Operating System and Arch

Ubuntu 20.04 armv7

🌐 Browser

Chrome 130

🖥️ Deployment Environment

• Runtime: Version: 27.3.1
  API version: 1.47
  Go version: go1.22.7

• Database: sqlite

• Filesystem used to store the database on: EXT4

• number of monitors: 200+

📝 Relevant log output

2024-10-31T15:38:19-04:00 [MONITOR] WARN: Monitor #174 'API check': Failing: Error evaluating JSON query: Invalid condition null. Response from server was: true | Interval: 600 seconds | Type: json-query | Down Count: 0 | Resend Interval: 0

[CommanderStorm]

That is a bit unfortunate.

uptime-kuma/db/knex_migrations/2024-04-26-0000-snmp-monitor.js

Line 6 in 0254e72

table.string("json_path_operator").defaultTo(null);

null should have been "=="
Will provide a PR

I also just noticed that I might have merged the same/overlapping functionality twice.
(compare the way monitor conditions for the dns monitor work vs the json monitor.. 🫤)

[mmomjian]

Thank you! I did the migration on a copy of my data so I am not planning on using this version in prod. Glad it can be fixed