Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheritance w/ Schema: ClassVar[Type[Schema]] is broken as of 8.5.6 #192

Open
ghost opened this issue Apr 27, 2022 · 0 comments
Open

Inheritance w/ Schema: ClassVar[Type[Schema]] is broken as of 8.5.6 #192

ghost opened this issue Apr 27, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 27, 2022

PR #189 introduced a regression where inheritance between dataclasses w/ explicit ClassVar[Type[Schema]]'s in parents is broken. The WAR from the PR was to drop it off of parents, but it'd be nice to see it fixed for those of us that love type-checking and hinting.

From that PR's comment chain:

@dataclass
class ThingA:
    Schema: ClassVar[Type[Schema]]
    name: str

@dataclass
class ThingB(ThingA):
    Schema: ClassVar[Type[Schema]]
    short_name: str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants