-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese input does not work properly when a function is passed to innerRef #176
Comments
Thanks for reporting this and same issue for Chinese as well |
I got the same issue for Chinese inputting. |
For me, the workaround (i.e. removing I think this issue is related to facebook/react#3926 . In the comments there are some workarounds that may be applicable here. |
Overview
When a function is passed as innerRef, typing Japanese text (and probably other texts that require text conversion) does not work properly.
Detail
The animation below is the expected behavior. Japanese uses several kinds of characters (hiragana, katakana, and kanji; kanji is basically Chinese character). When we want to type Kanji we first type hiragana and then convert it to kanji from the list of possible candidates.
The animation below is working example. As I type hiragana I see a box appears which shows the list of candidate conversions to kanji.
But when a function is passed as innerRef, the conversion box does not appear and the characters are automatically converted to the sequence of alphabets and hiragana, as you can see in the animation below.
Reproducing the problem
Reproducing code is available from here.
Possible solution
I found that removing
props.innerRef !== nextProps.innerRef
part incomponentShouldUpdate
solves this problem.But I am pretty sure this line is there because it is needed, so I doubt removing this line is the correct measure.
The text was updated successfully, but these errors were encountered: