Skip to content

Commit c123fa7

Browse files
author
Thomasr
committed
querytimeout unit to second, limit to max, rename env variable
1 parent aaae226 commit c123fa7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

server/api-service/lowcoder-domain/src/main/java/org/lowcoder/domain/query/util/QueryTimeoutUtils.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919
@Component
2020
public final class QueryTimeoutUtils {
2121

22-
private static int defaultQueryTimeoutMillis = 10000;
22+
private static int defaultQueryTimeout = 10;
2323

2424
@Value("${default.query-timeout}")
25-
public void setDefaultQueryTimeoutMillis(int defaultQueryTimeoutMillis) {
26-
QueryTimeoutUtils.defaultQueryTimeoutMillis = defaultQueryTimeoutMillis;
25+
public void setDefaultQueryTimeoutMillis(int defaultQueryTimeout) {
26+
QueryTimeoutUtils.defaultQueryTimeout = defaultQueryTimeout;
2727
}
2828

2929
public static int parseQueryTimeoutMs(String timeoutStr, Map<String, Object> paramMap, int maxQueryTimeout) {
@@ -33,7 +33,7 @@ public static int parseQueryTimeoutMs(String timeoutStr, Map<String, Object> par
3333
@VisibleForTesting
3434
public static int parseQueryTimeoutMs(String timeoutStr, int maxQueryTimeout) {
3535
if (StringUtils.isBlank(timeoutStr)) {
36-
return defaultQueryTimeoutMillis;
36+
return Math.min(defaultQueryTimeout * 1000, (int)Duration.ofSeconds(maxQueryTimeout).toMillis());
3737
}
3838

3939
Pair<String, Integer> unitInfo = getUnitInfo(timeoutStr);

server/api-service/lowcoder-server/src/main/resources/application-debug.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ logging:
5454
org.lowcoder: debug
5555

5656
default:
57-
query-timeout: ${LOWCODER_DEFAULT_QUERY_TIMEOUT_MILLIS:10000}
57+
query-timeout: ${LOWCODER_DEFAULT_QUERY_TIMEOUT:10s}

server/api-service/lowcoder-server/src/main/resources/application.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ default:
5353
org-app-count: ${LOWCODER_MAX_APPS_PER_ORG:1000}
5454
developer-count: ${LOWCODER_MAX_DEVELOPERS:50}
5555
api-rate-limit: ${LOWCODER_API_RATE_LIMIT:50}
56-
query-timeout: ${LOWCODER_DEFAULT_QUERY_TIMEOUT_MILLIS:10000}
56+
query-timeout: ${LOWCODER_DEFAULT_QUERY_TIMEOUT:10}
5757

5858
common:
5959
cookie-name: LOWCODER_CE_SELFHOST_TOKEN

0 commit comments

Comments
 (0)