Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crop cover image #36

Open
yurkobb opened this issue Jan 22, 2020 · 2 comments
Open

Don't crop cover image #36

yurkobb opened this issue Jan 22, 2020 · 2 comments

Comments

@yurkobb
Copy link

yurkobb commented Jan 22, 2020

Why should we mimic proprietary networks with enforcing a single cover image size for all people? Let folks use whatever image size they want as long as it doesn't exceed certain file size (1mb)? If it looks ugly, the users themselves will adapt it if they will feel a need.

@dariusk
Copy link
Contributor

dariusk commented Jan 25, 2020

For what it's worth, the image itself actually isn't cropped: if you upload a square image, it is stored as a square image, it is simply rendered in the banner as a long banner-type image.

@yurkobb
Copy link
Author

yurkobb commented Jan 25, 2020

Sure (I though it was just a css max-height or something), but I mean the final end-user experience more than how the image is processed (or not) technically. It would be good to allow different image aspect ratios, and simply put some maximum on the far side of the image (whichever it is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants