Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussions: GitHub emojis render as undefined #747

Closed
lowlighter opened this issue Jan 7, 2022 Discussed in #740 · 0 comments · Fixed by #754
Closed

discussions: GitHub emojis render as undefined #747

lowlighter opened this issue Jan 7, 2022 Discussed in #740 · 0 comments · Fixed by #754

Comments

@lowlighter
Copy link
Owner

Discussed in #740

Originally posted by cherryblossom000 January 5, 2022
Example

discussions section of rendered SVG, showing ‘undefined General Feedback’

The emoji of the General Feedback category is :octocat:. This is rendered as undefined, even if config_gemoji: true.

Possible fix:

for (const category of [...fetched.map(({category:{emoji, name}}) => `${imports.emoji.get(emoji)} ${name}`)])

- for (const category of [...fetched.map(({category:{emoji, name}}) => `${imports.emoji.get(emoji)} ${name}`)]) 
+ for (const category of fetched.map(({category:{emoji, name}}) => `${imports.emoji.get(emoji) ?? emoji} ${name}`))
```</div>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant