Skip to content

Commit 8a865db

Browse files
committed
test: reduce number of written chunks
Reduce chances of write errors while the request is sent. Refs: nodejs#56756
1 parent 1760024 commit 8a865db

6 files changed

+35
-25
lines changed

test/parallel/test-http-server-headers-timeout-delayed-headers.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,12 @@ server.listen(0, common.mustCall(() => {
5353

5454
sendDelayedRequestHeaders = common.mustCall(() => {
5555
setTimeout(() => {
56-
client.write('POST / HTTP/1.1\r\n');
57-
client.write('Content-Length: 20\r\n');
58-
client.write('Connection: close\r\n\r\n');
59-
client.write('12345678901234567890\r\n\r\n');
56+
client.write(
57+
'POST / HTTP/1.1\r\n' +
58+
'Content-Length: 20\r\n' +
59+
'Connection: close\r\n\r\n' +
60+
'12345678901234567890\r\n\r\n'
61+
);
6062
}, common.platformTimeout(headersTimeout * 2)).unref();
6163
});
6264
}));

test/parallel/test-http-server-headers-timeout-interrupted-headers.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,11 @@ server.listen(0, common.mustCall(() => {
5050
client.on('error', errOrEnd);
5151

5252
client.resume();
53-
client.write('GET / HTTP/1.1\r\n');
54-
client.write('Connection: close\r\n');
55-
client.write('X-CRASH: ');
53+
client.write(
54+
'GET / HTTP/1.1\r\n' +
55+
'Connection: close\r\n' +
56+
'X-CRASH: '
57+
);
5658

5759
sendDelayedRequestHeaders = common.mustCall(() => {
5860
setTimeout(() => {

test/parallel/test-http-server-request-timeout-delayed-body.js

+6-5
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,12 @@ server.listen(0, common.mustCall(() => {
4646
}));
4747

4848
client.resume();
49-
client.write('POST / HTTP/1.1\r\n');
50-
client.write('Host: example.com\r\n');
51-
client.write('Content-Length: 20\r\n');
52-
client.write('Connection: close\r\n');
53-
client.write('\r\n');
49+
client.write(
50+
'POST / HTTP/1.1\r\n' +
51+
'Host: example.com\r\n' +
52+
'Content-Length: 20\r\n' +
53+
'Connection: close\r\n\r\n'
54+
);
5455

5556
sendDelayedRequestBody = common.mustCall(() => {
5657
setTimeout(() => {

test/parallel/test-http-server-request-timeout-delayed-headers.js

+6-4
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,12 @@ server.listen(0, common.mustCall(() => {
4848

4949
sendDelayedRequestHeaders = common.mustCall(() => {
5050
setTimeout(() => {
51-
client.write('POST / HTTP/1.1\r\n');
52-
client.write('Content-Length: 20\r\n');
53-
client.write('Connection: close\r\n\r\n');
54-
client.write('12345678901234567890\r\n\r\n');
51+
client.write(
52+
'POST / HTTP/1.1\r\n' +
53+
'Content-Length: 20\r\n' +
54+
'Connection: close\r\n\r\n' +
55+
'12345678901234567890\r\n\r\n'
56+
);
5557
}, common.platformTimeout(requestTimeout * 2)).unref();
5658
});
5759
}));

test/parallel/test-http-server-request-timeout-interrupted-body.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,13 @@ server.listen(0, common.mustCall(() => {
5757
client.on('end', errOrEnd);
5858

5959
client.resume();
60-
client.write('POST / HTTP/1.1\r\n');
61-
client.write('Host: example.com\r\n');
62-
client.write('Content-Length: 20\r\n');
63-
client.write('Connection: close\r\n');
64-
client.write('\r\n');
65-
client.write('1234567890');
60+
client.write(
61+
'POST / HTTP/1.1\r\n' +
62+
'Host: example.com\r\n' +
63+
'Content-Length: 20\r\n' +
64+
'Connection: close\r\n\r\n' +
65+
'1234567890'
66+
);
6667

6768
sendDelayedRequestBody = common.mustCall(() => {
6869
setTimeout(() => {

test/parallel/test-http-server-request-timeout-interrupted-headers.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,11 @@ server.listen(0, common.mustCall(() => {
4545
client.on('error', errOrEnd);
4646

4747
client.resume();
48-
client.write('GET / HTTP/1.1\r\n');
49-
client.write('Connection: close\r\n');
50-
client.write('X-CRASH: ');
48+
client.write(
49+
'GET / HTTP/1.1\r\n' +
50+
'Connection: close\r\n' +
51+
'X-CRASH: '
52+
);
5153

5254
sendDelayedRequestHeaders = common.mustCall(() => {
5355
setTimeout(() => {

0 commit comments

Comments
 (0)