Skip to content

Commit a492646

Browse files
authored
tools: disable automated libuv updates
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: nodejs#51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
1 parent a5376c5 commit a492646

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

.github/workflows/tools.yml

+12-9
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ on:
2727
- googletest
2828
- histogram
2929
- icu
30-
- libuv
30+
# - libuv
3131
- lint-md-dependencies
3232
- llhttp
3333
- minimatch
@@ -174,14 +174,17 @@ jobs:
174174
cat temp-output
175175
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
176176
rm temp-output
177-
- id: libuv
178-
subsystem: deps
179-
label: dependencies
180-
run: |
181-
./tools/dep_updaters/update-libuv.sh > temp-output
182-
cat temp-output
183-
tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
184-
rm temp-output
177+
# libuv update was disabled because of Feb 14, 2024 security releas
178+
# modified the bundled version of libuv, we cannot automatically update
179+
# libuv without potentially undoing those changes.
180+
# - id: libuv
181+
# subsystem: deps
182+
# label: dependencies
183+
# run: |
184+
# ./tools/dep_updaters/update-libuv.sh > temp-output
185+
# cat temp-output
186+
# tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
187+
# rm temp-output
185188
- id: lint-md-dependencies
186189
subsystem: tools
187190
label: tools

0 commit comments

Comments
 (0)