Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated HttpClientTestingModule with new providers provideHttpClient()and provideHttpClientTesting() #9052

Open
krusche opened this issue Jul 14, 2024 · 1 comment
Open

Replace deprecated HttpClientTestingModule with new providers provideHttpClient()and provideHttpClientTesting() #9052

krusche opened this issue Jul 14, 2024 · 1 comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) good first issue tests

Comments

@krusche
Copy link
Member

krusche commented Jul 14, 2024

HttpClientTestingModule is deprecated and should be replaced with the following two providers

provideHttpClient()
provideHttpClientTesting()

There are around 150 occurrences that need to be migrated

A working example can be seen on learning-path-lecture-unit.component.spec.ts
@krusche krusche added good first issue tests client Pull requests that update TypeScript code. (Added Automatically!) labels Jul 14, 2024
@krusche krusche changed the title Replace deprecated Replace deprecated HttpClientTestingModule with new providers provideHttpClient()and provideHttpClientTesting() Jul 14, 2024
@krusche
Copy link
Member Author

krusche commented Jul 14, 2024

This is an example that I pushed to develop in 5739e96
The patch is attached and needs to be applied 150x more times 😊

0001-Development-Replace-deprecated-HttpClientTestingModu.patch

@coderabbitai coderabbitai bot mentioned this issue Sep 9, 2024
Merged
11 tasks
@coderabbitai coderabbitai bot mentioned this issue Jan 2, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client Pull requests that update TypeScript code. (Added Automatically!) good first issue tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krusche