Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create activity endpoint for bad practice detection(#223) #224

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

iam-flo
Copy link
Contributor

@iam-flo iam-flo commented Jan 17, 2025

Motivation

We create a dashboard that displays current pull requests together with detected bad practices

Description

Create a activity endpoint to get and detect bad practices in PRs.
Visualize PRs and bad practices in a dashboard

Testing Instructions

Run application server and client.
Access: http://localhost:4200/activity/iam-flo

Screenshots (if applicable)

Bildschirmfoto 2025-01-17 um 18 23 42

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

Server (if applicable)

  • Code is performant and follows best practices
  • No security vulnerabilities introduced
  • Proper error handling has been implemented

@iam-flo iam-flo linked an issue Jan 17, 2025 that may be closed by this pull request
@github-actions github-actions bot added application-server size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
@github-actions github-actions bot added client size:XL This PR changes 500-999 lines, ignoring generated files. size:XXL This PR changes 1000+ lines, ignoring generated files. and removed autocommit-openapi size:L This PR changes 100-499 lines, ignoring generated files. size:XL This PR changes 500-999 lines, ignoring generated files. labels Jan 17, 2025
@iam-flo iam-flo force-pushed the 223-creating-activity-dashboard branch 2 times, most recently from 92b2879 to 372ac51 Compare January 28, 2025 10:21
@@ -49,7 +50,8 @@ export const routes: Routes = [
{ path: 'user/:id', component: UserProfileComponent },
{ path: 'settings', component: SettingsComponent },
{ path: 'mentor', component: MentorComponent, canActivate: [MentorGuard] },
{ path: 'workspace', component: WorkspaceComponent, canActivate: [AdminGuard] }
{ path: 'workspace', component: WorkspaceComponent, canActivate: [AdminGuard] },
{ path: 'activity/:id', component: ActivityDashboardComponent }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To stay consistent with our user pages, would it make sense to move this path to user/:id/activity?

@iam-flo iam-flo force-pushed the 223-creating-activity-dashboard branch from 72b78fa to 98d9c8e Compare February 4, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application-server client size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating activity dashboard
2 participants