Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hyperlink rendering #192

Closed
pothos opened this issue Apr 26, 2019 · 4 comments · Fixed by #642
Closed

Support hyperlink rendering #192

pothos opened this issue Apr 26, 2019 · 4 comments · Fixed by #642
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature request

Comments

@pothos
Copy link

pothos commented Apr 26, 2019

The --hyperlink option for ls¹ is allows to open a document/folder with the default (GUI) application by using Ctrl+click in various terminals.
It would be nice to have this in lsd.
See here for more info: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda

¹ http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=799bac0d06cfabe9491498727308df8d1aca6d98

exa issue: ogham/exa#396

@Peltoche
Copy link
Collaborator

Peltoche commented May 2, 2019

Hi @pothos

Thanks for the proposition. Personally I don't see the when this feature could be used (a filename with a link ??) but if someone needs it let's go for it. At the moment I don't have the time to write new features but I would review a PR with pleasure it you want to make one.

@meain meain added the kind/enhancement Enhancement on current feature label Jun 7, 2019
@xenopeek
Copy link

xenopeek commented Aug 5, 2019

Running ls --hyperlink in any VTE based terminal (like Gnome Terminal) lets you ctrl+click any file in the ls output to open it with its default filetype handler (or open the link through context menu). i.e., ctrl+click a text file opens the file in your text editor, ctrl+click a directory opens the directory in your file manager and so on. Quite handy, try it out.

@KSXGitHub KSXGitHub mentioned this issue Apr 18, 2020
@KSXGitHub
Copy link
Contributor

I have made a pull request for initial support. But I am way too tired to fix any remaining issue. Seriously, reading this codebase is like traversing a labyrinth

@meain meain added good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature request and removed kind/enhancement Enhancement on current feature labels Feb 6, 2022
@meain meain mentioned this issue Mar 27, 2022
5 tasks
@ppwwyyxx
Copy link

ppwwyyxx commented Feb 3, 2023

The implementation of hyperlink support in #642 does not match the recommendation in the OSC8 spec here https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda#file-uris-and-the-hostname that suggests hostname to be included in the hyperlink. This is what ls --hyperlink does as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants