Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.9 => "Failed test 'Saving sketches" #37

Closed
tseemann opened this issue Feb 19, 2019 · 3 comments
Closed

v0.4.9 => "Failed test 'Saving sketches" #37

tseemann opened this issue Feb 19, 2019 · 3 comments

Comments

@tseemann
Copy link

t/02_lambda.t ............. 2/6
    #   Failed test 'MD5 of sample1.fastq.gz.msh'
    #   at t/02_lambda.t line 96.
    #          got: 'f52e4232f5c7c46e77a15a9ac7ee1bfd'
    #     expected: 'b737ed5e87f4851181c0f3027848ab4b'

    #   Failed test 'MD5 of sample4.fastq.gz.msh'
    #   at t/02_lambda.t line 96.
    #          got: 'd4e868824b2bae710aaad61da87d13ec'
    #     expected: '53d545265d37632dbfcb0d2556e8aba6'

    #   Failed test 'MD5 of sample2.fastq.gz.msh'
    #   at t/02_lambda.t line 96.
    #          got: '68df1823233fbea03e82778b3c3c4a2e'
    #     expected: '90e5a975176b4add3eb13891a1ee8368'

    #   Failed test 'MD5 of sample3.fastq.gz.msh'
    #   at t/02_lambda.t line 96.
    #          got: '5d9db49d34e6193cfca45db1005613ef'
    #     expected: '52fbe9f503f240065def9872cfd8e308'
    # Looks like you failed 4 tests of 4.

#   Failed test 'Saving sketches'
#   at t/02_lambda.t line 99.
# Looks like you failed 1 test of 6.
t/02_lambda.t ............. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/6 subtests
@lskatz
Copy link
Owner

lskatz commented Feb 19, 2019

ack you are right, I will mark the release as alpha. I don't think that this one test failure will hurt anything but I just want to be careful. Thank you for bringing it to my attention

@lskatz
Copy link
Owner

lskatz commented Feb 20, 2019

I discovered that the sketch contains an absolute path to the original fastq file, making everyone's sketches unique. Therefore this was not a good test in the script. If this was your only error, then you can be worry-free. I will work to resolve this issue over the next week when I have time.

@lskatz
Copy link
Owner

lskatz commented Mar 8, 2019

fixed in 5900f9a but I don't have a new cpan release yet due to limited time

@lskatz lskatz closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants