Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Sending message in Quickmail with embedded Images breaks image link when opening in email #287

Open
will-bulluck opened this issue Sep 6, 2019 · 2 comments

Comments

@will-bulluck
Copy link

Hello,

I recently discovered that when you send a message from the quickmail block in a course, where the e=message has embedded images the embedded image link is broken, I have attached a screenshot of the email

Email_footer

As you can see in the above image, when the email is sent out from Moodle there has been a "=" inserted in mod_label in the URL
.
Thanks,

Will

@haietza
Copy link

haietza commented Nov 8, 2019

I think this is actually related to #26 (the = symbol appears in the original email source at all the line breaks of the code and does not cause images from forum posts to break).

We are seeing the same issue of images not displaying (in at least the Gmail web client) on Moodle 3.6 and v2.2.0 2019012401 of the Quickmail plugin. It does not work even if the user is authenticated into Moodle. Is Gmail a "thick" email app? Has there been any discussion about allowing every request to embedded content to come through? The image URLs that are coming through for us with images embedded in the text editor show as draft file links; not sure if this might be the issue?

The problem for us is that students have no way of seeing sent messages from Quickmail, so the only way they can view that content is through the email message.

@haietza
Copy link

haietza commented Nov 12, 2019

I just tested the plugin with a non-draftfile URL (hard-coded image from a forum post) for the img src and it still does not display in Gmail, even when logged into Moodle. Images ARE displaying for forum posts, however. It appears the only difference in the img src URL between the two is the forum post uses tokenpluginfile.php and Quickmail uses pluginfile.php or draftfile.php. When I used the hard coded img src URL with the tokenpluginfile.php in the path in the Quickmail message, the images displays in Gmail. Is this the URL that does not check for permissions? Please advise, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants