Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Smarty3 be part of the dependencies managed by Composer? #728

Closed
alcorwalter opened this issue Oct 25, 2022 · 8 comments
Closed

Can Smarty3 be part of the dependencies managed by Composer? #728

alcorwalter opened this issue Oct 25, 2022 · 8 comments
Labels

Comments

@alcorwalter
Copy link

I can't install SSP by a system package, Smarty3 either, especially since it forces the installation of PHP which is already installed by a third party application.
This makes the installation and maintenance of SSP very tedious.
If Smarty3 could be installed by Composer, like other components, it would be easier. Is this technically possible?

@coudot
Copy link
Member

coudot commented Oct 25, 2022

Removing dependencies is not a good solution, the SSP package is tested in latest distributions and it works great (except current bug in Debian, see #681).

To us your own PHP/Smarty, either install from sources, or build your own packages or Docker image.

@alcorwalter
Copy link
Author

If installed by system package, you can keep package dependency.
If installed manually, you can add composer dependency ?
It can really help when using shared hosting (plesk, etc)

@coudot
Copy link
Member

coudot commented Oct 25, 2022

Sorry, this is not clear for me. If you can install SSP manually, you should be able to install composer.

@alcorwalter
Copy link
Author

I thought that your lib/composer.json may add smarty3 in his dependencies ; so i can execute composer install to get the right version of smarty3, in the right place. but i'm not a coder so i may misunderstood the usage of composer.

@coudot
Copy link
Member

coudot commented Oct 25, 2022

We currently use composer for some dependencies that we ship into lib/vendor, you don't need to run composer install at all with SSP, composer is only use on dev side.

@alcorwalter
Copy link
Author

OK I understand. (I must confess I do regret that Smarty3 is not managed this way).
That's not hard to add and configure with SSP but it would be transparent if it came with it.
I think we can close this issue / request.

@stevleibelt
Copy link
Contributor

@coudot as @alcorwalter mentioned it, would it make sense to close this issue?

@coudot
Copy link
Member

coudot commented May 12, 2023

Indeed, I close this issue.

Smarty can be installed as package on RHEL / Debian, or from an archive (see the Dockerfile).

@coudot coudot closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants