Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self-service-password debian package not depending on smarty #825

Closed
davidcoutadeur opened this issue Jan 15, 2024 · 4 comments
Closed

self-service-password debian package not depending on smarty #825

davidcoutadeur opened this issue Jan 15, 2024 · 4 comments
Labels
dependencies Pull requests that update a dependency file packaging question

Comments

@davidcoutadeur
Copy link

I don't know if it is really intended, but self-service-password debian package doesn't show smarty dependency:

Package: self-service-password
Version: 1.5.4-1
Priority: extra
Section: web
Source: ltb-project-self-service-password
Maintainer: Clement Oudot <clem@ltb-project.org>
Installed-Size: 6 774 kB
Depends: php5 | php, php5-gd | php-gd, php5-ldap | php-ldap, php5-mbstring | php-mbstring

Leading to the expected error:

[Mon Jan 15 14:02:05.725909 2024] [php7:error] [pid 567] [client 62.146.238.221:62012] PHP Fatal error:  require_once(): Failed opening required '/usr/share/php/smarty3/Smarty.class.php' (include_path='.:/usr/share/php') in /usr/share/self-service-password/htdocs/index.php on line 179

Maybe should we add the dependency

@davidcoutadeur
Copy link
Author

For reference, there is a note here in the documentation:

https://self-service-password.readthedocs.io/en/stable/installation.html#debian-ubuntu

The debian smarty3 package seems compatible

@coudot
Copy link
Member

coudot commented Jan 15, 2024

See #681

@davidcoutadeur
Copy link
Author

Thanks for the pointer.

When the fix is available on all supported plaforms of self-service-password, we may add the dependency again...

@coudot coudot added question packaging dependencies Pull requests that update a dependency file labels Feb 3, 2024
@coudot
Copy link
Member

coudot commented Apr 26, 2024

The dependency was added again in 1.6

@coudot coudot closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file packaging question
Projects
None yet
Development

No branches or pull requests

2 participants