Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting the CL into parts with suggested approach #21

Closed
ltilve opened this issue Jun 5, 2015 · 3 comments
Closed

Splitting the CL into parts with suggested approach #21

ltilve opened this issue Jun 5, 2015 · 3 comments

Comments

@ltilve
Copy link
Owner

ltilve commented Jun 5, 2015

From https://codereview.chromium.org/1152613003/#msg15

I think we should split it up into (at least) 3. The first one should include
no "real" UI code - that is, it shouldn't have anything touched in ui/views or
ui/cocoa, and you can probably leave out a little of the stuff in, e.g.,
ui/browser. The second should add the views implementation, and the third
should add the cocoa implementation.

@ltilve
Copy link
Owner Author

ltilve commented Jun 8, 2015

We have been splitting into a smaller set of buildable parts to be grouped into a reasonable patchgroup here https://github.com/ltilve/chromium/commits/igalia-sidebar-CL-splitted

@ltilve
Copy link
Owner Author

ltilve commented Jun 10, 2015

@ltilve
Copy link
Owner Author

ltilve commented Jun 17, 2015

With all the additional modifications, the code is properly fragmented according to Devlin criteria. The pending modifications related with the tests to be tracked at #24

@ltilve ltilve closed this as completed Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant