-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search functionality #8
Comments
For this one we have a patch pending |
Your patch is filtering using python and doesn't paginate (major sin). So far it searches by |
Yes, it is filtering in python also because text search in SQL depends on the different engine implementations. I am not sure how the ORM deals with that. Given the size of data involved I think it is reasonable and we have an implementation ~1.5 years after the issue was opened but I will not prevent someone else to come up with a better solution :) |
The solution now is in the tree ;)
|
Great! |
Should we close this one? I will take a look to learn something :) |
I'll close it tomorrow once I land the rest retouches.
|
the whoosh integration with sqlalchemy I was using is too brittle. |
Found a working version but this dhamaniasad/Flask-WhooshAlchemy#4 is missing. |
Should we close this one? |
The ability to search over all the fields of patches
The text was updated successfully, but these errors were encountered: