-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to require decomposer within a package? #9
Comments
If you require it in a package, and on installing that package Decomposer too will get installed in the vendor directory just like the other dependencies. Also why are you making that static call? Getting the report as an array anywhere in the code is the feature coming tomorrow in the v1.1 release :) |
Lol, I'm not actually making that static call xD |
@dducro but when the package goes live & is installed it will install decomposer in the correct place too. Why would someone need it until there is a complete app supposed to be decomposed? |
It installs in the correct place. But it throws an error in DecomposerController.php on line 55 if done so. I created a pr: #10 |
@dducro Merged! Thank you for the PR Daniel :) |
It's expected that the package is installed in a Laravel project.
DecomposerController::getLaravelEnv()
line: 55
However when including it from a package this line fails because decomposer isn't a dependency of the parent project.
The text was updated successfully, but these errors were encountered: