implement HTTP/3 control stream handling #2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
==========================================
+ Coverage 86.04% 86.39% +0.35%
==========================================
Files 134 134
Lines 9286 9790 +504
==========================================
+ Hits 7990 8458 +468
- Misses 938 968 +30
- Partials 358 364 +6
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
http3-control-streams
branch
from
fe30d87
to
f754bb2
Compare
marten-seemann
force-pushed
the
http3-control-streams
branch
from
f754bb2
to
a19c957
Compare
lucas-clemente
approved these changes
Dec 22, 2020
| for { | ||
| str, err := sess.AcceptUniStream(context.Background()) | ||
| if err != nil { | ||
| return |
There was a problem hiding this comment.
Can/should we somehow handle the error? Log at least?
There was a problem hiding this comment.
Same for the other exit points in this fn.
| for { | ||
| str, err := c.session.AcceptUniStream(context.Background()) | ||
| if err != nil { | ||
| return |
marten-seemann
force-pushed
the
http3-control-streams
branch
from
a19c957
to
808671e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll need this if we ever want to read the SETTINGS frame. This frame is used to negotiate HTTP/3 extensions.