Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace dropping of 0-RTT keys #3054

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Conversation

marten-seemann
Copy link
Member

No description provided.

Client and server only possess write or read 0-RTT keys, respectively.
We should therefore only emit a single event when those are dropped.
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #3054 (110f949) into master (9b627ac) will decrease coverage by 0.03%.
The diff coverage is 55.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3054      +/-   ##
==========================================
- Coverage   86.19%   86.16%   -0.03%     
==========================================
  Files         132      132              
  Lines        9347     9354       +7     
==========================================
+ Hits         8056     8059       +3     
- Misses        935      938       +3     
- Partials      356      357       +1     
Impacted Files Coverage Δ
internal/handshake/crypto_setup.go 66.19% <0.00%> (-0.64%) ⬇️
qlog/qlog.go 90.98% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b627ac...110f949. Read the comment docs.

@marten-seemann marten-seemann merged commit 1c9977d into master Mar 2, 2021
@marten-seemann marten-seemann deleted the trace-dropped-0rtt-keys branch March 3, 2021 03:28
@aschmahmann aschmahmann mentioned this pull request May 14, 2021
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants