Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize hasOutstandingCryptoPackets in sentPacketHandler #3230

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #3230 (6279d6b) into master (746358c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
+ Coverage   85.47%   85.48%   +0.01%     
==========================================
  Files         133      133              
  Lines        9794     9793       -1     
==========================================
  Hits         8371     8371              
+ Misses       1051     1050       -1     
  Partials      372      372              
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 78.23% <100.00%> (-0.05%) ⬇️
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 746358c...6279d6b. Read the comment docs.

Copy link
Contributor

@AudriusButkevicius AudriusButkevicius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@marten-seemann marten-seemann merged commit 8906148 into master Jul 25, 2021
@marten-seemann marten-seemann deleted the optimize-has-outstanding-crypto-packets branch July 25, 2021 18:35
@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants