Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the SkipSchemeCheck RoundTripOpt #3353

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

marten-seemann
Copy link
Member

This option was needed for an early draft version of MASQUE.
MASQUE now uses the https scheme.

This option was needed for an early draft version of MASQUE.
MASQUE now uses the https scheme.
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #3353 (fe901f4) into master (b7e93b5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3353   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files         135      135           
  Lines        9837     9837           
=======================================
  Hits         8413     8413           
  Misses       1046     1046           
  Partials      378      378           
Impacted Files Coverage Δ
http3/roundtrip.go 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e93b5...fe901f4. Read the comment docs.

@marten-seemann marten-seemann merged commit 85b4954 into master Mar 25, 2022
nmldiegues pushed a commit to chungthuang/quic-go that referenced this pull request Jun 6, 2022
This option was needed for an early draft version of MASQUE.
MASQUE now uses the https scheme.
@marten-seemann marten-seemann deleted the remove-skip-scheme-check branch January 25, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants