protect against concurrent use of Stream.Read #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3380 +/- ##
=======================================
Coverage 85.58% 85.58%
=======================================
Files 135 135
Lines 9872 9875 +3
=======================================
+ Hits 8448 8451 +3
Misses 1047 1047
Partials 377 377
Continue to review full report at Codecov.
|
AnomalRoil
approved these changes
Apr 22, 2022
lucas-clemente
approved these changes
Apr 25, 2022
nmldiegues
pushed a commit
to chungthuang/quic-go
that referenced
this pull request
Jun 6, 2022
41 tasks
sudarshan-reddy
pushed a commit
to sudarshan-reddy/quic-go
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrent use of Read is not permitted (and doesn't make any sense), but sometimes people do it anyway.
In this case, it's easy and cheap enough to protect against misuse of the API, and means we don't have to debug failures that look like quic-go bugs but are really bugs in the user's code. See #3376 for an example.