-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement a new API to let servers control client address verification #3501
Conversation
8bc1532
to
5da735a
Compare
5da735a
to
ab82346
Compare
This looks better! So basically, if I understand right, I would implement |
Exactly! All the token validation logic is now handled under the hood (tunable using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like just what I was hoping for then. Thank you!
df8d9a2
to
2ee3bcc
Compare
We should provide safe defaults. Since we implement the 3x amplification limit, disabling address validation is not unsafe, and will save 1 RTT for every handshake for applications that don't explicitely configure Retries.
2ee3bcc
to
bbfb7bd
Compare
Codecov Report
@@ Coverage Diff @@
## master #3501 +/- ##
==========================================
- Coverage 85.69% 85.69% -0.00%
==========================================
Files 136 136
Lines 9995 9992 -3
==========================================
- Hits 8565 8562 -3
Misses 1052 1052
Partials 378 378
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@marten-seemann Excellent! I updated caddyserver/caddy#4707 and it seems to be working (haven't tested the "highLoad" scenario but HTTP/3 works by default). |
I need this upgraded to avoid dependency conflict in storj.io/ipfs-go-ds-storj Note that AcceptToken has been removed in recent guic-go releases, and address verification is disabled by default. So we don't need to set it anyway. Details here: quic-go/quic-go#3501 Change-Id: I6682ac45e4de8d36002630fff75f6d6072c5010d
Fixes #3494.
This PR makes 2 changes:
@mholt, would be happy about your feedback on this PR!