-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome 45 #20
Comments
Oh, my 😮 Is it reasonable to make a change that will literally break all extensions? I'm not sure whether it will be possible to make the extension work with GNOME 45 and, when possible, how much work it will require. Let's keep this issue active. Thank you for the update! Please, consider taking a look at extension.js to check how the extension works. Maybe it's easy to solve it. |
I tried looking into it myself, with my fairly limited (read: none) knowledge of the gnome desktop. I followed the gnome guide to migrate extensions but quickly ran into an error that told me Is it even possible to do this in Gnome 45? o.O |
There are quite a lot of changes in Gnome 45, btw. They have made an official guide for migrating extensions, but it doesn't help with the issue of certain things now being read-only and no longer replacable. |
Hi everyone, I tried to fork and work on this, this is my first time contributing on Gnome extensions, so I had to read quite a lot of documentation to (kind of) understand how to use things, and didn't come to a working solution (yet). However, I wanted to share the progress, just in case. Of course, if it's completely out of topic or doesn't help resolving the problem, don't mind it. I tried to work around what @Goldpaw said, indeed, I first tried to keep the classes defined in the extension, extending the Finally, I removed the Everything is on my fork, on the Again, sorry if everything is completely wrong 😅 Cheers ! PS : btw, don't mind the |
Hey guys, I'm also new here 👋 I think I've got it working for I came across another Alt+Tab related extension that overrides the So, I used his code as a base and simplified it until I reached this: my fork Here's the main part:
For some reason it's not working for |
Oh if I had found this |
Got it working on
Don't even get me started! I spent the entire day on this poorly documented thing 😅 If it weren't for other similar extensions, I would have given up already |
Dang ! Got it working too with the |
Sure! Feel free to suggest anything, here it is: #21 It's still very hacky, so I'll appreciate your review! |
Okay I didn't want to put too much review since we went different ways, so I opened mine : #22 Let's discuss and see what we can do (or not hahaha) ! Cheers |
@ld-web Thanks for the suggestion! It indeed feels lighter having ps: I just realized we are 3 Lucas's working on this project 😄 |
Nice ! I didn't notice for PS : Hahaha uniting Lucas' forces ! 💪🏻 |
Hey, guys! Thank you very much for this amazing discussion! I'm loving this haha I'll review the pull request soon, thank you so much! |
The glory of open source. Windows and mac users definitely haven't got this kind of community! ;) |
I am happy to announce the extension now supports GNOME 45! Changes are still in the I'll close this issue, but feel free to share more information if necessary. Thank you for all work on this, specially @ld-web and @lbltavares for coming up with the solutions. Cheers! |
Can you please add support for Gnome 45? Gnome Shell 45 has a breaking change (another one, right?) for Extensions: https://blogs.gnome.org/shell-dev/2023/09/02/extensions-in-gnome-45/
The text was updated successfully, but these errors were encountered: