Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BottomSheetPosition not the same across device types #26

Closed
jordibruin opened this issue Sep 3, 2021 · 3 comments · Fixed by #79
Closed

BottomSheetPosition not the same across device types #26

jordibruin opened this issue Sep 3, 2021 · 3 comments · Fixed by #79
Labels
bug Something isn't working Thank You ❤️ For people who appreciate my work

Comments

@jordibruin
Copy link

I've made a custom bottom sheet position, but it seems that the height percentage is not calculated in the same way for an iPhone XS Max and an iPhone 8 Plus.

I would expect that some space would be visible on top of the bottom sheet on the iPhone 8 Plus as well.

This is my custom bottomsheetPosition:

enum SettingsBottomSheetPosition: CGFloat, CaseIterable {
	case top = 0.95, middle = 0.8, hidden = 0
}

And these are my options:

let settingsOptions: [BottomSheet.Options] = [
		.swipeToDismiss, .tapToDissmiss, .showCloseButton(), .noBottomPosition, .background(AnyView(Color(.systemGroupedBackground))) ]

See screenshots:
Simulator Screen Shot - iPhone 8 Plus - 2021-09-03 at 19 46 44
Simulator Screen Shot - iPhone 12 Max - 2021-09-03 at 19 41 57

@lucaszischka lucaszischka added the bug Something isn't working label Sep 3, 2021
@lucaszischka lucaszischka self-assigned this Sep 3, 2021
@lucaszischka
Copy link
Owner

Hello Jordi,

I‘m currently at vacation, but as soon as I’m back home I will have a look. My current guess is that is due to the save area differences between these devices.

Greetings,
Lucas

@jordibruin
Copy link
Author

No rush Lucas, I will have a look myself as well! Thanks for making this great package 🙂

@lucaszischka lucaszischka added the Thank You ❤️ For people who appreciate my work label Sep 4, 2021
@lucaszischka lucaszischka added the help wanted Extra attention is needed label Jun 17, 2022
@lucaszischka
Copy link
Owner

lucaszischka commented Jun 17, 2022

If anyone wants to help by investigating this, it would be appreciated.

@lucaszischka lucaszischka removed their assignment Jun 17, 2022
@lucaszischka lucaszischka linked a pull request Jul 22, 2022 that will close this issue
@lucaszischka lucaszischka added this to the v3 milestone Jul 22, 2022
@lucaszischka lucaszischka removed the help wanted Extra attention is needed label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Thank You ❤️ For people who appreciate my work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants