Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document correct way to run the tests #258

Open
mithro opened this issue Jun 18, 2016 · 5 comments
Open

Document correct way to run the tests #258

mithro opened this issue Jun 18, 2016 · 5 comments

Comments

@mithro
Copy link
Contributor

mithro commented Jun 18, 2016

I couldn't find anywhere which documented the correct way to run all the tests for the code. At the moment, I've been doing a git cl presubmit

@maruel
Copy link
Member

maruel commented Jun 21, 2016

"git cl pr" is what I use too. Each unit test can also executed by itself. Do you advocate to note this in README.md?

@mithro
Copy link
Contributor Author

mithro commented Jun 22, 2016

Yes, I advocate putting this note in README.md

@mithro
Copy link
Contributor Author

mithro commented Jun 22, 2016

Another thing to note is that when you run "git cl presubmit" there is no output which says "ran X number of tests which all succeeded" or similar so it isn't necessarily clear that the tests have actually run.

Actually, I have no idea if my ar tests are getting run as part of this or not....

@maruel
Copy link
Member

maruel commented Jun 22, 2016

git cl pres -v
will print out more details.
presubmit checks are not meant as a general purpose mechanism to run unit tests, more to do non-executable checks so it should probably be moved over. A simple python script at root could fix this, that's what exists in infra.

@mithro
Copy link
Contributor Author

mithro commented Jun 22, 2016

Many python projects will use a test runner like nose or py.test but I'm not sure that is the correct solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants
@mithro @maruel and others