Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlQuery.execute() and StatementPreparer.execute() have incorrect documentation #70

Open
richard-shurtz opened this issue Mar 2, 2020 · 0 comments

Comments

@richard-shurtz
Copy link
Contributor

SqlQuery.execute() indicates @return whether the query succeeded in its execution
And
StatementPrepared.execute() indicates return if the query succeeded or not
But the underlying jdbc documentation indicates true if the first result is a ResultSet object; false if it is an update count or there are no results [https://docs.oracle.com/javase/7/docs/api/java/sql/Statement.html#execute(java.lang.String)]

In practice, any INSERT statement executed with .execute() returns false, which the Relate documentation would have you believe indicates that the query failed somehow.

We should update the documentation to match the jdbc documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant