Flash messages are not maintained with multiple redirects.

[wout]

In continuation of #1160.

[wout]

Ok, I've located the issue and found an easy fix but before I make a PR, I would like to discuss the changes.

Let's say we have the following setup:

• SignIns::Create redirects to Home::Index and sets a flash.success = "Yay!"
• Home::Index redirects to Dashboard::Index and does not set a flash

The Home::Index action does not consume the flash, so when you arrive at Dashboard::Index, the flash has been lost. An easy fix is to recycle the flash on redirects. That's something we can add here:

module Lucky::Redirectable
  # ...
  def redirect(to path : String, status : Int32 = 302) : Lucky::TextResponse
    flash.recycle
    # ...
  end
  # ...
end

Its functionality would be:

class Lucky::FlashStore
  # ...
  def recycle : Void
    @next = @now
  end
  # ...
end

What do you think?

[confact]

I had the same issue myself. Good catch @wout!

I think that sounds good, but maybe some setting/param to disable the flash on redirect if you want to for some reason.

[wout]

@confact I've also been thinking about that. But if you don't want the flash messages to be recycled, you could always explicitly clear the flash:

class Home::Index < BrowserAction
  get "/home" do
    flash.clear
    redirect Dashboard::Index
  end
end

I found that to be convenient enough. :)

[confact]

A yeah. That's even better :)

[paulcsmith]

Love it! I think flash.recycle in the redirect helper is perfect, and clearing the flash should work great if you no longer want it.

The only suggestion I have (which shouldn't stop a PR) is to call it Flash#reuse. but maybe that's worse. Either way not a big deal since will likely only be used internally by Lucky 👍