Pluralize doesn't take Int64

[jwoertink]

If you use select_count, it will return Int64, but passing that to pluralize will throw

no overload matches 'SomePage#pluralize' with types Int64, String

https://github.com/luckyframework/lucky/blob/master/src/lucky/page_helpers/text_helpers.cr#L89

My guess is we should probably also support Int16. Maybe we just have a few overloads that convert the type, and pass to a main method?

[paulcsmith]

Nice catch. I think we could use a union type there so it accepts all the Int types

…

On Sep 3, 2019, at 1:50 PM, Jeremy Woertink ***@***.***> wrote: If you use select_count, it will return Int64, but passing that to pluralize will throw no overload matches 'SomePage#pluralize' with types Int64, String https://github.com/luckyframework/lucky/blob/master/src/lucky/page_helpers/text_helpers.cr#L89 My guess is we should probably also support Int16. Maybe we just have a few overloads that convert the type, and pass to a main method? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[vinibrsl]

Would it be bad to just accept Int? That would cover the following types: BigInt, Int16, Int32, Int64, Int8, UInt16, UInt32, UInt64, UInt8

[paulcsmith]

Yeah that’s a great idea!