Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated Operations to new structure #574

Closed
jwoertink opened this issue Nov 2, 2020 · 4 comments · Fixed by #575
Closed

Update generated Operations to new structure #574

jwoertink opened this issue Nov 2, 2020 · 4 comments · Fixed by #575

Comments

@jwoertink
Copy link
Member

With luckyframework/avram#469 being merged in, Operations now have a new interface. We need to make sure all of the generated operations are updated to use these.

@bcardiff
Copy link
Contributor

bcardiff commented Nov 5, 2020

I guess I've just stumbled on this one when checking avram + lucky + lucky_cli on master

$ lucky init.custom lucky101 --api
$ cd lucky101
$ shards
$ shards build
# Dependencies are satisfied
# Building: lucky101
# Error target lucky101 failed to compile:
# Using compiled compiler at /__w/test-ecosystem/test-ecosystem/crystal/.build/crystal
# In lib/avram/src/avram/operation.cr:81:16
# 
#  81 | abstract def run
#                    ^--
# Error: abstract `def Avram::Operation#run()` must be implemented by RequestPasswordReset
# 

@jwoertink
Copy link
Member Author

oof 😣 sorry about that. I have #575 to fix it, but this repo is sort of a mess at the moment. Maybe I just need to merge all of these things now and fix it once everything is merged in. You're not the first this week that has run in to it. I'll try to get that fixed now.

@bcardiff
Copy link
Contributor

bcardiff commented Nov 5, 2020

No rush on my side. :-) the other specs passes on test-ecosystem so far https://github.com/bcardiff/test-ecosystem/runs/1359933202?check_suite_focus=true

@jwoertink
Copy link
Member Author

Ok, these should be all good now @bcardiff. Hopefully they all work on your test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants