Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive msgpack2json with maps #4

Closed
xor-gate opened this issue Sep 20, 2016 · 4 comments
Closed

Recursive msgpack2json with maps #4

xor-gate opened this issue Sep 20, 2016 · 4 comments

Comments

@xor-gate
Copy link
Contributor

xor-gate commented Sep 20, 2016

Hi Nicolas,

I'm using the msgpack2json tool to convert a messagepack logfile to json.
How the file is formatted (where every map is a log record):

<map>5 key-values</map>
<map>5 key-values</map>...... many more

Currently the tool only converts the first map and then stops. I know it is not valid JSON but is it possible to fetch all the maps until the file is done (and all map records are converted)?

@ludocode
Copy link
Owner

Yes, this is definitely something it should do. I originally had it expecting exactly one element (a JSON "document"), but JSON doesn't even have the concept of a document anymore, and I added support for hooking it up to a stream for RPC-type stuff so it really doesn't make sense for it to only convert one element.

I'll fix it.

@rpodgorny
Copy link

time for a release, perhaps? i'm also waiting for this feature. thanks... ;-)

@ludocode
Copy link
Owner

Fixed on develop. I'm putting together a 0.6 release now.

@xor-gate
Copy link
Contributor Author

Great, nice to see you again :=)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants