-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLS profiles for easier configuration #1441
Conversation
Thanks for the PR! I subscribed to the flex plan and created a database. However, when I wanted to connect to it with the following code: const client = new Redis({
host: "redis-xxx.us-east-1-mz.ec2.cloud.rlrcp.com",
password: "xxxxxx",
port: 13342,
tls: 'RedisCloudFlexible',
}); I got the following error:
Did I miss anything? |
I'm afraid I only have access to the fixed plan right now and can't reproduce your error on our databases on there. Looks like the flex plans are charged monthly, otherwise I'd make a quick test subscription myself 😅 |
@luin I've been in contact with Redis.com and got a flexible suscription to test with. Turns out the flexible CA from their site was missing a part of the certificate chain. They've sent me the correct CA now and I've updated the PR with it. On my own flexible subscription it is working fine now. |
Awesome! Thanks for the contribution 🥳 |
# [4.28.0](v4.27.11...v4.28.0) (2021-10-13) ### Features * **tls:** add TLS profiles for easier configuration ([#1441](#1441)) ([4680211](4680211))
🎉 This PR is included in version 4.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
but why? looks like it is a bad idea to store certificates inside package, to maintain it and make the certificate list dependant on package version |
# [4.28.0](redis/ioredis@v4.27.11...v4.28.0) (2021-10-13) ### Features * **tls:** add TLS profiles for easier configuration ([#1441](redis/ioredis#1441)) ([4680211](redis/ioredis@4680211))
Inspired by seeing this in MySQL libraries (mysql and mysql2), this PR adds support for specifying a TLS profile that takes care of configuring for example redis.com's certificate authority.