fix: fix a memory leak with autopipelining. #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set kCallbacks field to null instead of the empty array because nothing should append to it until a new pipeline starts. If anything did, that is a bug. With Redis.Cluster, there could be 16384 different arrays pointing to callbacks that aren't needed.
TysonAndre
force-pushed
the
kCallbacks-free-early
branch
from
f2df554
to
fb100ff
Compare
luin
changed the title
|
🎉 This PR is included in version 4.28.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
janus-dev87
added a commit
to janus-dev87/ioredis-work
that referenced
this pull request
Mar 1, 2024
## [4.28.2](redis/ioredis@v4.28.1...v4.28.2) (2021-12-01) ### Bug Fixes * add Redis campaign ([#1475](redis/ioredis#1475)) ([3f3d8e9](redis/ioredis@3f3d8e9)) * fix a memory leak with autopipelining. ([#1470](redis/ioredis#1470)) ([f5d8b73](redis/ioredis@f5d8b73)) * unhandled Promise rejections in pipeline.exec [skip ci] ([#1466](redis/ioredis#1466)) ([e5615da](redis/ioredis@e5615da))
This was referenced Jul 18, 2024
This was referenced Jul 29, 2024
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set kCallbacks field to null instead of the empty array because nothing
should append to it until a new pipeline starts.
If anything did, that is a bug.
With Redis.Cluster, there could be 16384 different arrays pointing to
callbacks that aren't needed.
Memory impact probably isn't significant if those all point to Promises to resolve/reject,
though I guess the resolved data could itself be large in some cases