Merge pull request #3 from lukachad/concurrency

Browser streams support & concurrency

Author: lukachad

.vscode/settings.json

@@ -11,5 +11,6 @@
     "source.fixAll.eslint": "explicit"
   },
   "typescript.tsdk": "node_modules/typescript/lib",
-  "vitest.disableWorkspaceWarning": true
+  "vitest.disableWorkspaceWarning": true,
+  "java.configuration.updateBuildConfiguration": "interactive"
 }

lib/lib-storage/src/s3-transfer-manager/S3TransferManager.e2e.spec.ts

@@ -31,16 +31,13 @@ describe(S3TransferManager.name, () => {
   let region: string;
 
   beforeAll(async () => {
-    // const integTestResourcesEnv = await getIntegTestResources();
-    // Object.assign(process.env, integTestResourcesEnv);
+    const integTestResourcesEnv = await getIntegTestResources();
+    Object.assign(process.env, integTestResourcesEnv);
 
-    // region = process?.env?.AWS_SMOKE_TEST_REGION as string;
-    // Bucket = process?.env?.AWS_SMOKE_TEST_BUCKET as string;
+    region = process?.env?.AWS_SMOKE_TEST_REGION as string;
+    Bucket = process?.env?.AWS_SMOKE_TEST_BUCKET as string;
     void getIntegTestResources;
 
-    region = "us-west-2";
-    Bucket = "lukachad-us-west-2";
-
     client = new S3({
       region,
     });
@@ -54,7 +51,7 @@ describe(S3TransferManager.name, () => {
     });
   }, 120_000);
 
-  describe.skip("multi part download", () => {
+  describe("multi part download", () => {
     const modes = ["PART", "RANGE"] as S3TransferManagerConfig["multipartDownloadType"][];
     const sizes = [6, 11] as number[];
 
@@ -92,13 +89,11 @@ describe(S3TransferManager.name, () => {
             },
             {
               eventListeners: {
-                transferInitiated: [({ request, snapshot }) => {}],
                 bytesTransferred: [
                   ({ request, snapshot }) => {
                     bytesTransferred = snapshot.transferredBytes;
                   },
                 ],
-                transferComplete: [({ request, snapshot, response }) => {}],
               },
             }
           );
@@ -151,7 +146,7 @@ describe(S3TransferManager.name, () => {
       const serialized = await download.Body?.transformToString();
       check(serialized);
       if (partNumber) {
-        expect(serialized?.length).toEqual(DEFAULT_PART_SIZE);
+        expect(serialized?.length).toEqual(4 * 1024 * 1024); // Part 1 is 8MB Part 2 is 4MB
       } else {
         expect(serialized?.length).toEqual(Body.length);
       }
@@ -163,10 +158,11 @@ describe(S3TransferManager.name, () => {
     it("multipart object: multipartDownloadType = RANGE, range = 0-12MB, partNumber = null", async () => {
       await sepTests("multipart", "RANGE", `bytes=0-${12 * 1024 * 1024}`, undefined);
     }, 60_000);
-    it("single object: multipartDownloadType = PART, range = null, partNumber = 2", async () => {
+    // skipped because TM no longer supports partNumber
+    it.skip("single object: multipartDownloadType = PART, range = null, partNumber = 2", async () => {
       await sepTests("single", "PART", undefined, 2);
     }, 60_000);
-    it("single object: multipartDownloadType = RANGE, range = null, partNumber = 2", async () => {
+    it.skip("single object: multipartDownloadType = RANGE, range = null, partNumber = 2", async () => {
       await sepTests("single", "RANGE", undefined, 2);
     }, 60_000);
     it("single object: multipartDownloadType = PART, range = null, partNumber = null", async () => {