Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order_by title does not work with folder #73

Closed
ChrisBlankDe opened this issue May 2, 2023 · 3 comments · Fixed by #75
Closed

order_by title does not work with folder #73

ChrisBlankDe opened this issue May 2, 2023 · 3 comments · Fixed by #75
Labels
bug Something isn't working

Comments

@ChrisBlankDe
Copy link

the new order_by feature works great with multible files in one directory. Thank you!

But the new feature does not work with directories:

directory tree:

│   mkdocs.yml
└───docs
    │   .pages
    │   index.md
    ├───1
    │       .pages (Title: A (1))
    │       index.md
    ├───2
    │       .pages (Title: C (2))
    │       index.md
    ├───3
    │       .pages (Title: B (3))
    │       index.md
    └───4
            .pages (Title: D (4))
            index.md

.pages at root level:

nav: 
  - Home: index.md
  - ... | flat
order_by: title

My expection was that the groups where sorted by name (from the .pages in sub dir: A, B, C, D) but they are sorted by the name of the directory (1, 2, 3, 4):
image

My minimized demo solution:
mkdocs-awesome-order-by-folder.zip

Is this behavior intentional or is it a bug?

@lukasgeiter lukasgeiter added the bug Something isn't working label May 2, 2023
@kamilkrzyskow
Copy link
Contributor

This is a bug, edge case which I completely overlooked, since I'm not using the .pages file to change the title.
Should probably be an easy fix, because now it's sort of ignoring the custom title from the .pages file.

@kamilkrzyskow
Copy link
Contributor

Thanks for the reproduction @ChrisBlankDe ✌️
image

@lukasgeiter
Copy link
Owner

Fixed in v2.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants