Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename css custom properties with component name prefix & undo -default #4

Open
lukaskoeller opened this issue Feb 20, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@lukaskoeller
Copy link
Owner

Motivation

When @layer is implemented, there is no real reason for using a -default fallback in the css custom properties since styling conflicts are solved through that.
Furthermore, to make usage of higher up defined css custom properties in usage more clear, they should be prefixed with their component name.

Example

<fd-section>
    <fd-gallery style="--fd-gallery-gap: var(--fd-section-padding-inline)">
        ...
    </fd-gallery>
</fd-section>

Here, it is clear that I want to have the <fd-gallery> gap to always be the inline padding of <fd-section>.

@lukaskoeller lukaskoeller added the enhancement New feature or request label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant