Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could be possible to switch to gix? #66

Open
lu-zero opened this issue May 16, 2024 · 5 comments
Open

Could be possible to switch to gix? #66

lu-zero opened this issue May 16, 2024 · 5 comments

Comments

@lu-zero
Copy link

lu-zero commented May 16, 2024

It would be less problematic than relying on the presence of libgit2.

I can contribute the code to switch to it if you deem it acceptable.

@lukaslueg
Copy link
Owner

That's certainly possible, although reliability / platform compatibility would be paramount.

There has been ongoing work (and) to add the required features to gitoxide. If you ping @Byron, he may be able to guide towards what's left to do.

@lu-zero
Copy link
Author

lu-zero commented May 16, 2024

I see he started working on a new branch. I forgot the dirty check is missing :)

@Byron
Copy link

Byron commented May 16, 2024

Indeed, there really is 'just' this PR missing which I plan to work on for months now. It will happen though…I am just spread thin ATM.

@jayvdb
Copy link
Contributor

jayvdb commented Aug 30, 2024

GitoxideLabs/gitoxide#1368 was merged in June. Maybe this is now feasible?

@Byron
Copy link

Byron commented Aug 30, 2024

Please note that I have been using these PRs for other things and keep reopening them, so the mere merge doesn't really say much about its contents.
Thus, is_dirty isn't fully supported yet as it also needs a diff between a HEAD and the index, which isn't implemented yet.
And as I am tracking this and have it on my radar, you can trust I will be back here to finish the integration as soon as it's possible.

Let me finish with my sincere apologies for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants