Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The dependecy 'rollup-plugin-typescript' is deprecated #560

Open
kaffarell opened this issue Aug 25, 2020 · 9 comments · May be fixed by #568
Open

The dependecy 'rollup-plugin-typescript' is deprecated #560

kaffarell opened this issue Aug 25, 2020 · 9 comments · May be fixed by #568
Assignees
@kaffarell

Comments

@kaffarell
Copy link
Collaborator

we should change it to this '@rollup/plugin-typescript'. Don't know if this would brake anything.
@kaffarell
Copy link
Collaborator Author

I am going to try later today

@kaffarell
Copy link
Collaborator Author

Getting this error:

src/html5sortable.ts → dist/html5sortable.min.js...
[!] (plugin typescript) Error: @rollup/plugin-typescript TS2339: Property 'items' does not exist on type 'string | void | HTMLElement | configuration'.
  Property 'items' does not exist on type 'string'.
__tests__/api.test.ts (38:19)

38       expect(opts.items).toEqual('li')
                     ~~~~~

Error: @rollup/plugin-typescript TS2339: Property 'items' does not exist on type 'string | void | HTMLElement | configuration'.
  Property 'items' does not exist on type 'string'.
    at error (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup/dist/shared/rollup.js:5171:30)
    at throwPluginError (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup/dist/shared/rollup.js:17396:12)
    at Object.error (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup/dist/shared/rollup.js:18017:24)
    at emitDiagnostic (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/@rollup/plugin-typescript/dist/index.js:415:17)
    at reportDiagnostics (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/@rollup/plugin-typescript/dist/index.js:423:9)
    at Array.forEach (<anonymous>)
    at emitFilesAndReportErrors (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/typescript/lib/typescript.js:105331:21)
    at Object.result.afterProgramCreate (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/typescript/lib/typescript.js:105501:13)
    at Object.afterProgramCreate (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/@rollup/plugin-typescript/dist/index.js:515:29)
    at synchronizeProgram (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/typescript/lib/typescript.js:105765:22)

Don't know what is causing this... the tests shouldn't be affected...

@lukasoppermann
Copy link
Owner

Hey, this is just a typescript error. Try replacing:

const opts = sortable.__testing.data(ul, 'opts')

with

const opts = <configuration>sortable.__testing.data(ul, 'opts')

On line 37.

@kaffarell kaffarell self-assigned this Aug 28, 2020
@kaffarell
Copy link
Collaborator Author

kaffarell commented Aug 29, 2020 •
edited
Loading

This did not fix the issue, but I run into a lot of issues with using @rollup/plugin-typescript in personal projects. Although it is the official plugin it still has a lot of issues and is not really popular. I think we should go with the updated version of the previously used plugin rollup-plugin-typescript3. What do you think @lukasoppermann ?

@lukasoppermann
Copy link
Owner

Sounds good. Let's go ahead with the updated version than. 👍

I updated to the new one for my website, but that was a bit easier I think. Had only 5 things to update. 😁

@kaffarell
Copy link
Collaborator Author

html5sortable/src/html5sortable.ts

Lines 180 to 182 in cc69e7f

const spanEl = (document || window.document).createElement('span')
if (typeof spanEl.dragDrop === 'function') {
on(handles, 'mousedown', function () {

I am getting an error here... the dragDrop property is not defined, also couldn't find it in the type declarations. Above this piece of code there is this comment:

  // @todo: remove this fix
  // IE FIX for ghost
  // can be disabled as it has the side effect that other events
  // (e.g. click) will be ignored

@lukasoppermann
Copy link
Owner

Hey @kaffarell what are the exact errors you get?

Do remove this fix we would first need to figure out what IE version needs it. If IE11 does need it, it would maybe be better to stick with it as optional but we could definitely move it into its own file.

@kaffarell
Copy link
Collaborator Author

Sorry for the long delay, had a lot to do lately..
This is the exact error I get:

[!] (plugin rpt2) Error: /home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/src/html5sortable.ts(181,23): semantic error TS2339: Property 'dragDrop' does not exist on type 'HTMLSpanElement'.
src/html5sortable.ts
Error: /home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/src/html5sortable.ts(181,23): semantic error TS2339: Property 'dragDrop' does not exist on type 'HTMLSpanElement'.
    at error (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup/dist/shared/rollup.js:5215:30)
    at throwPluginError (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup/dist/shared/rollup.js:17838:12)
    at Object.error (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup/dist/shared/rollup.js:18443:24)
    at Object.error (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup/dist/shared/rollup.js:18007:38)
    at RollupContext.error (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup-plugin-typescript2/src/rollupcontext.ts:37:18)
    at /home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup-plugin-typescript2/src/print-diagnostics.ts:41:11
    at arrayEach (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup-plugin-typescript2/node_modules/lodash/lodash.js:516:11)
    at Function._.each [as forEach] (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup-plugin-typescript2/node_modules/lodash/lodash.js:9368:14)
    at printDiagnostics (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup-plugin-typescript2/src/print-diagnostics.ts:9:2)
    at Object.transform (/home/gabriel/Desktop/Open-Source/html5sortable/html5sortable/node_modules/rollup-plugin-typescript2/src/index.ts:242:5)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! html5sortable@0.9.18 build: `rollup -c && cp $npm_package_main docs/html5sortable.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the html5sortable@0.9.18 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/gabriel/.npm/_logs/2020-10-14T11_44_46_561Z-debug.log

@kaffarell
Copy link
Collaborator Author

I am gonna test this later today on IE...

@kaffarell kaffarell linked a pull request Oct 14, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaffarell kaffarell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Update rollup-plugin-typescript to rollup-plugin-typescript2 lukasoppermann/html5sortable
2 participants
@lukasoppermann @kaffarell