Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate NewUnlockedSessionFromConn to PseudoFS and PseudoKV #94

Closed
jkawamoto opened this issue Aug 5, 2020 · 4 comments
Closed

Integrate NewUnlockedSessionFromConn to PseudoFS and PseudoKV #94

jkawamoto opened this issue Aug 5, 2020 · 4 comments

Comments

@jkawamoto
Copy link
Contributor

jkawamoto commented Aug 5, 2020 •
edited
Loading

NewUnlockedSessionFromConn implemented with #93 would reduce this kind of error: "NewUnlockedSession: dial tcp 72.66.79.45:9982: connect: connection timed out". So, it'd be nice PseudoFS uses it by default.

Related to #67.
@lukechampine
Copy link
Owner

In #95 I added support for custom lock timeouts to HostSet, but I'm not sure how to support custom conns. Can you suggest an API?

@jkawamoto
Copy link
Contributor Author

As same as #95, adding SetDialTimeout and SetHandshakeTimeout to HostSet would be good.

@lukechampine
Copy link
Owner

Ah, I was thinking we'd need to allow passing entire net.Conns, but your suggestion should work fine.

@jkawamoto
Copy link
Contributor Author

Alternatively, it'd be possible to add ConnectionOpener interface but I think it's too much.

@jkawamoto jkawamoto changed the title Integrate NewUnlockedSessionFromConn to PseudoFS Integrate NewUnlockedSessionFromConn to PseudoFS and PseudoKV Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkawamoto @lukechampine