Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: why did you not choose the while loop? #28

Closed
rohit2sharma95 opened this issue Oct 26, 2021 · 1 comment · Fixed by #29
Closed

Question: why did you not choose the while loop? #28

rohit2sharma95 opened this issue Oct 26, 2021 · 1 comment · Fixed by #29

Comments

@rohit2sharma95
Copy link
Contributor

Seems that while loop is a good fit here:

dset/src/index.js

Line 4 in 6515792

for (; i < l;) {

And the for loop is made less readable by changing syntax IMO 🙂
@rohit2sharma95 rohit2sharma95 mentioned this issue Oct 26, 2021
Merged
@lukeed
Copy link
Owner

lukeed commented Oct 27, 2021 •
edited
Loading

Thanks, it was just code-style :) Accepted the PR only because it was 2B smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use while loop
2 participants
@lukeed @rohit2sharma95