Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themes for PowerShell 5 #10

Closed
balbano opened this issue Sep 12, 2015 · 8 comments
Closed

Update themes for PowerShell 5 #10

balbano opened this issue Sep 12, 2015 · 8 comments

Comments

@balbano
Copy link

balbano commented Sep 12, 2015

Many of the themes behave poorly with the new syntax highlighting in powershell 5. For example, typing numbers in many of the light themes results in white on white, or close to it, and typing command line flags in many of the dark themes results in grey on grey, or close to it. The new Mountain theme seems to do okay.

Examples

white_on_white_numbers

flags_hard_to_read

@lukesampson
Copy link
Owner

Yeah I think this is the new ps-readline stuff.

I've used

set-psreadlineoption -t parameter darkblue
set-psreadlineoption -t operator darkblue
set-psreadlineoption -t string darkgreen

... to get mine looking better for now. This isn't a solution, just mentioning it now until I get a chance to fix this properly.

@mrmckeb
Copy link

mrmckeb commented Oct 22, 2015

Thanks @lukesampson - I didn't realise it was because of the new PowerShell, as I hadn't used it prior. Makes sense.

@ionTea
Copy link

ionTea commented Feb 22, 2016

Hey, I have the same problem and i'm not used to powershell so i have no idea where to look in order to fix this. Where can i find the config file to add the above temp-fix?

@lukesampson
Copy link
Owner

@ionTea you can add the above commands to your powershell profile (e.g. notepad $profile) to save them.

@AdrianoCahete
Copy link

Still have a problem when start character is $:
colors2

Any fix?

@nwykes
Copy link

nwykes commented Jun 16, 2016

@AdrianoCahete if you're still have a problem with the $ it can be set with:
set-psreadlineoption -t variable darkblue

@adautoneto
Copy link
Contributor

If you are using the solarized theme, I fixed some hard to read colors and also replaced others to make them better (in my opinion). I created the PR #20 for those who'd like to try it and maybe to be merged to this repo.

@chawyehsu
Copy link
Collaborator

chawyehsu commented May 17, 2018

https://github.com/h404bi/base16-concfg#about-command-line-token-colors
When I regenerate the presets with the base16 architecture, I met this problem while using those generated presets, then I found the reason, and gave a workaround. I think that's the finial solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants