Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded ICS file is invalid #1389

Closed
smncd opened this issue Oct 11, 2024 · 1 comment
Closed

Downloaded ICS file is invalid #1389

smncd opened this issue Oct 11, 2024 · 1 comment

Comments

@smncd
Copy link
Contributor

smncd commented Oct 11, 2024

Hey! Been playing around with Rallly and really impressed so far!

I noticed that the content of the ICS file that you can download after a poll is finalized is url encoded (data:text/calendar;charset=utf8,BEGIN:VCALENDAR%0D%0AVERSION:2.0 [...]).
Due to this, the file can't be imported, or at least it does not work when I've tried it with Proton- and Google calendar.

When trying to pinpoint the issue, I came across this: https://github.com/lukevella/rallly/blob/main/apps/web/src/components/add-to-calendar-button.tsx#L125. Creating a blob here means that the url encoded string is what gets put in the downloaded ics file.

Happy to open a PR for this if you're interested.

Cheers!

To Reproduce
Steps to reproduce the behavior:

  1. Create poll
  2. Mark as completed
  3. Download ICS file
  4. Try to add to your calendar of choice, or open as plaintext.
@smncd smncd changed the title Downloaded ICS fiile is invalid Downloaded ICS file is invalid Oct 11, 2024
@smncd
Copy link
Contributor Author

smncd commented Oct 11, 2024

Actually, seems it was a pretty easy fix. PR here: #1390

@smncd smncd closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant