Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOREPLY_EMAIL is marked as optional but produces error regardless #1433

Open
1ukastesar opened this issue Nov 9, 2024 · 2 comments
Open
Labels

Comments

@1ukastesar
Copy link

1ukastesar commented Nov 9, 2024

Describe the bug
NOREPLY_EMAIL in the config file (config.env) is documented the way that when it is not set, SUPPORT_EMAIL will be used instead - so as an optional setting.

But for some reason this doesn't work and produces error in the logs:

❌ Invalid environment variables: { NOREPLY_EMAIL: [ 'Invalid email' ] }

To Reproduce

  1. Leave NOREPLY_EMAIL blank in the config.env
  2. Run Rallly app (through e.g. docker compose up)

Expected behavior
The unset or empty variable should not print any error.

Screenshots
not applicable

Desktop (please complete the following information):

  • OS: Ubuntu 24.04
  • Browser: not applicable
  • Version: v3.11.2

Smartphone (please complete the following information):
not applicable

Additional context
not applicable

@lukevella
Copy link
Owner

I can reproduce this if I leave NOREPLY_EMAIL inside config.env:

NOREPLY_EMAIL=

I imagine what's happening is that this is considered to be an empty string which is enough to trigger the email validation. Perhaps running email validation in this case is not really necessary or the validation can be modified to allow empty string. I will consider changing this.

In the mean time you should be able to comment the line out or remove it completely to fix it.

# NOREPLY_EMAIL=

@1ukastesar
Copy link
Author

In the mean time you should be able to comment the line out or remove it completely to fix it.

# NOREPLY_EMAIL=

Thank you for your quick response. I can confirm that commenting the option out helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants