Skip to content
This repository has been archived by the owner on Mar 26, 2022. It is now read-only.

Make role objects to pivot models #636

Open
kdmnk opened this issue Oct 29, 2021 · 2 comments
Open

Make role objects to pivot models #636

kdmnk opened this issue Oct 29, 2021 · 2 comments
Labels
refactor/rebase Changing the structure of the code or modifying representations

Comments

@kdmnk
Copy link
Collaborator

kdmnk commented Oct 29, 2021

see here: https://laravel.com/docs/8.x/eloquent-relationships#defining-custom-intermediate-table-models (idk whether it is good for us)
@kdmnk kdmnk added the refactor/rebase Changing the structure of the code or modifying representations label Oct 29, 2021
@luksan47
Copy link
Owner

Might be if we are using it as often as we use roles. Worth some time to investigate.

@kdmnk
Copy link
Collaborator Author

kdmnk commented Oct 30, 2021

I just find it unneccessary (and strange) if we are making models (sort of) from these objects anyways (see toSelectableCollection function).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactor/rebase Changing the structure of the code or modifying representations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luksan47 @kdmnk