Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP9] Should we add ERC1271 to verify signatures at the vault #116

Open
frozeman opened this issue Aug 29, 2022 · 1 comment
Open

[LSP9] Should we add ERC1271 to verify signatures at the vault #116

frozeman opened this issue Aug 29, 2022 · 1 comment

Comments

@frozeman
Copy link
Member

frozeman commented Aug 29, 2022

Adding ERC1271 isValidSignature() to an LSP9 vault would allow for login with a vault. Then vault would then call the isValidSignature() on the owner, to see if the signature can be verified by one of the SIGN keys controlling the UP/ower contract.

currently LSP9 does not have ERC1271, as any app can always detect the owner and call isValidSignature() on the owner himself.

@DanielAbalde
Copy link

We can't call isValidSignature() from an EOA, so adding ERC1271 depends on whether you want an EOA to be able to sign on an LSP9, right? If this is the case, I think it is good to add it and that the Lukso ecosystem is not closed to UP however better it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants