-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add payable on up constructor
/ initializer(...)
#219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mark the initialize
function of UniversalProfileInit
as payable also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to allow this feature in th eproxy version.
This require some tests + probably the _initialize
function of LSP0ERC725AccountInitAbstract
and UniversalPofileInitAbstract
payable
too, so that the initialize(...) payable
function can pass the value down into the inheritance.
Below are the actual functions in the proxy that setup the UP and ERC725Account on deployment:
lsp-smart-contracts/contracts/LSP0ERC725Account/LSP0ERC725AccountInitAbstract.sol
Lines 15 to 17 in 53e33cc
function _initialize(address newOwner) internal virtual onlyInitializing { | |
OwnableUnset._setOwner(newOwner); | |
} |
lsp-smart-contracts/contracts/UniversalProfileInitAbstract.sol
Lines 20 to 25 in 53e33cc
function _initialize(address newOwner) internal virtual override onlyInitializing { | |
LSP0ERC725AccountInitAbstract._initialize(newOwner); | |
// set key SupportedStandards:LSP3UniversalProfile | |
_setData(_LSP3_SUPPORTED_STANDARDS_KEY, _LSP3_SUPPORTED_STANDARDS_VALUE); | |
} |
@CJ42 |
Ah thanks @YamenMerhi for the clarification. I did not know actually that |
constructor
/ initializer(...)
Thanks @Hugoo for this contribution! 🚀 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo:
Done with @CJ42