Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow deleting versions with aliases #24

Open
BeyondEvil opened this issue Mar 20, 2020 · 4 comments
Open

[Feature Request] Allow deleting versions with aliases #24

BeyondEvil opened this issue Mar 20, 2020 · 4 comments

Comments

@BeyondEvil
Copy link

Would you accept a PR that adds override capabilities so that one can delete versions that has aliases?

We have that use-case.

@theburningmonk
Copy link
Collaborator

sure, make it an explicit opt-in and it should be fine.
I'm curious though, what's the use case - i.e. why would you want to keep the alias but delete the underlying version?

@BeyondEvil
Copy link
Author

sure, make it an explicit opt-in and it should be fine.

Absolutely.

I'm curious though, what's the use case - i.e. why would you want to keep the alias but delete the underlying version?

We don't want to keep the alias. So the PR would include deleting the alias (required by AWS) before deleting the (function) version.

We have the entire publishing of our lambda functions automated and whenever we publish a new version we create an alias for that version using the commit hash and CI build number. So it's not an alias that is used for any other purposes than to have a historical reference.

Hope that makes sense. 😄

@theburningmonk
Copy link
Collaborator

Gotcha, makes sense.

@BeyondEvil
Copy link
Author

For transparency. I won't be doing this in the near future.

The reason is that we're using Terraform and they don't, currently, support SARs.

hashicorp/terraform-provider-aws#3981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants