fix: correct location reporting for !important in no-important rule (eslint#286)

* fix: correct location reporting for `!important` in `no-important` rule

* update tests to avoid problems with dedent in Bun

Author: sethamus

src/rules/no-important.js

@@ -54,7 +54,8 @@ export default {
 					const declarationText = sourceCode.getText(node);
 					const textWithoutComments = declarationText.replace(
 						commentPattern,
-						match => match.replace(/[^\n]/gu, " "),
+						/* eslint-disable-next-line require-unicode-regexp -- we want to replace each code unit with a space */
+						match => match.replace(/[^\n]/g, " "),
 					);
 					const importantMatch =
 						importantPattern.exec(textWithoutComments);

tests/rules/no-important.test.js

@@ -245,6 +245,24 @@ ruleTester.run("no-important", rule, {
 				},
 			],
 		},
+		{
+			code: "a { color: red /* comment with surrogate pairs: 👍🚀 */ !important; }",
+			errors: [
+				{
+					messageId: "unexpectedImportant",
+					line: 1,
+					column: 57,
+					endLine: 1,
+					endColumn: 67,
+					suggestions: [
+						{
+							messageId: "removeImportant",
+							output: "a { color: red /* comment with surrogate pairs: 👍🚀 */; }",
+						},
+					],
+				},
+			],
+		},
 		{
 			code: dedent`
 				a {
@@ -272,6 +290,25 @@ ruleTester.run("no-important", rule, {
 				},
 			],
 		},
+		{
+			// NOTE: dedent`` converts 👍🚀 to \u{1f44d}\u{1f680} in Bun, causing unexpected report locations
+			code: "a {\ncolor: red /* comment with surrogate pairs: 👍🚀 */\n!important;\n}",
+			errors: [
+				{
+					messageId: "unexpectedImportant",
+					line: 3,
+					column: 1,
+					endLine: 3,
+					endColumn: 11,
+					suggestions: [
+						{
+							messageId: "removeImportant",
+							output: "a {\ncolor: red /* comment with surrogate pairs: 👍🚀 */;\n}",
+						},
+					],
+				},
+			],
+		},
 		{
 			code: "a { color: red !/* comment */important; }",
 			errors: [
@@ -290,6 +327,24 @@ ruleTester.run("no-important", rule, {
 				},
 			],
 		},
+		{
+			code: "a { color: red !/* comment with surrogate pairs: 👍🚀 */important; }",
+			errors: [
+				{
+					messageId: "unexpectedImportant",
+					line: 1,
+					column: 16,
+					endLine: 1,
+					endColumn: 66,
+					suggestions: [
+						{
+							messageId: "removeImportant",
+							output: "a { color: red; }",
+						},
+					],
+				},
+			],
+		},
 		{
 			code: "a { color: red ! /* comment */ important; }",
 			errors: [
@@ -335,6 +390,25 @@ ruleTester.run("no-important", rule, {
 				},
 			],
 		},
+		{
+			// NOTE: dedent`` converts 👍🚀 to \u{1f44d}\u{1f680} in Bun, causing unexpected report locations
+			code: "a {\ncolor: red\n!/* comment with surrogate pairs: 👍🚀 */important;\n}",
+			errors: [
+				{
+					messageId: "unexpectedImportant",
+					line: 3,
+					column: 1,
+					endLine: 3,
+					endColumn: 51,
+					suggestions: [
+						{
+							messageId: "removeImportant",
+							output: "a {\ncolor: red;\n}",
+						},
+					],
+				},
+			],
+		},
 		{
 			code: dedent`
 				a {