fix(space):empty effect dependencies

lumium-technologies · Dec 29, 2022 · 9e28b51 · 9e28b51
1 parent 1b6525f
commit 9e28b51
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/lumium-space/pages/[workspaceId]/index.tsx b/lumium-space/pages/[workspaceId]/index.tsx
@@ -150,6 +150,7 @@ const NavItem = ({ icon, children, ...rest }: NavItemProps) => {
 interface MobileProps extends FlexProps {
     onOpen: () => void;
 }
+
 const MobileNav = ({ onOpen, ...rest }: MobileProps) => {
     return (
         <Flex
@@ -232,13 +233,16 @@ const Workspace: React.FC = () => {
     const router = useRouter();
     const { workspaceId } = router.query;
     const workspace = useWorkspace(workspaceId);
-    const { userInfo }= useUserInfo();
+    const { userInfo } = useUserInfo();
 
     return (
         <SidebarWithHeader>
-            <Heading>
-                Welcome to the <em>{workspace?.name}</em> workspace, {userInfo?.nickName}!
-            </Heading>
+            {
+                (workspace?.name && userInfo?.nickName) &&
+                    <Heading>
+                        Welcome to the <em>{workspace?.name}</em> workspace, {userInfo?.nickName}!
+                    </Heading>
+            }
             {
                 workspace?.pages.map((p) => {
                     return (

diff --git a/lumium-space/pages/spaces/[[...path]].tsx b/lumium-space/pages/spaces/[[...path]].tsx
@@ -22,7 +22,7 @@ const Spaces: React.FC = () => {
                 Router.push(AUTH_SIGNIN);
             }
         });
-    });
+    }, []);
 
     return null;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,7 +22,7 @@ const Spaces: React.FC = () => { @@
                     Router.push(AUTH_SIGNIN);
                 }
             });
-        });
+        }, []);
         return null;
     }
@@ Expand Down @@